Skip to content

[HiCache] Fix memory host free logic when share_indices_with_anchor enabled #22767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzh0425 merged 1 commit into from
Apr 15, 2026
+1 −7
Merged

[HiCache] Fix memory host free logic when share_indices_with_anchor enabled #22767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions python/sglang/srt/mem_cache/memory_pool_host.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1729,13 +1729,7 @@ def alloc(self, need_size: int) -> Optional[torch.Tensor]:
return self.anchor_entry.host_pool.alloc(need_size)

def free(self, indices: torch.Tensor) -> int:
n = self.anchor_entry.host_pool.free(indices)
for entry in self.entries:
if entry is self.anchor_entry:
continue
if getattr(entry, "share_indices_with_anchor", False):
entry.host_pool.free(indices)
return n
return self.anchor_entry.host_pool.free(indices)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the mirroring logic in free makes the documentation for share_indices_with_anchor in the PoolEntry dataclass (line 1666) stale and incorrect. It still claims that HostPoolGroup.free mirrors frees to the pool when this flag is enabled. Please update the comment in the PoolEntry definition to reflect that mirroring is no longer performed.


def get_data_page(self, index, flat: bool = True):
return self.anchor_entry.host_pool.get_data_page(index, flat)
Expand Down
Loading