[metrics] Add PoolStats.update_scheduler_stats to deduplicate metrics assignment#22559
Merged
[metrics] Add PoolStats.update_scheduler_stats to deduplicate metrics assignment#22559
PoolStats.update_scheduler_stats to deduplicate metrics assignment#22559Conversation
hnyls2002
requested review from
Ying1123,
merrymercy and
xiezhq-hermann
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
hnyls2002
force-pushed
the
lsyin/pool-stats-v2
branch
from
03f33eb to
0cbe25d
Compare
hnyls2002
changed the title
PoolStats.update_scheduler_stats to deduplicate metrics assignment
3 tasks
hnyls2002
force-pushed
the
lsyin/pool-stats-v2
branch
from
0cbe25d to
e9aad94
Compare
Collaborator
Author
|
/rerun-test test_scheduler_pause_generation.py |
Contributor
|
✅ |
Collaborator
Author
|
/rerun-test test_metrics.py test_prefill_delayer.py test_abort.py |
Contributor
|
✅ ✅ |
hnyls2002
changed the title
PoolStats.update_scheduler_stats to deduplicate metrics assignmentPoolStats.update_scheduler_stats to deduplicate metrics assignment
pyc96
pushed a commit
to pyc96/sglang
that referenced
this pull request
Apr 14, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_scheduler_stats()method toPoolStats— centralizes pool-related stats assignment (num_used_tokens,token_usage,full_token_usage,swa_token_usage,mamba_usage)check_memorywith a singlepool_stats.update_scheduler_stats(self.stats)callround(..., 2)fortoken_usage— previously only the idle path rounded, now all 3 paths are consistentFollows up on #22554.
Test plan
test_scheduler_pause_generation.py— CPU, mock PoolStats pathtest_metrics.py— verifiessglang:token_usagemetrictest_prefill_delayer.py— usestoken_usagefor delaytest_abort.py— exercises prefill/decode stats paths