[Spec][Ngram] Clean up unused stateless batchMatch#22487
Merged
hnyls2002 merged 1 commit intosgl-project:mainfrom Apr 11, 2026
Merged
[Spec][Ngram] Clean up unused stateless batchMatch#22487hnyls2002 merged 1 commit intosgl-project:mainfrom
batchMatch#22487hnyls2002 merged 1 commit intosgl-project:mainfrom
Conversation
Collaborator
Author
|
/tag-and-rerun-ci |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-test registered/unit/spec/test_ngram_corpus.py |
Collaborator
Author
|
/rerun-test test/registered/spec/test_ngram_speculative_decoding.py |
Contributor
|
✅ |
Contributor
|
✅ |
hnyls2002
approved these changes
Apr 11, 2026
pyc96
pushed a commit
to pyc96/sglang
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #21243,
Ngram::batchMatchbecame stateful. However there is still an old stateless relics left from before (possible result of merge conflicts resolution - my bad).Note: the stateful
batchMatchtakes inconst std::vector<int64_t>& state_idswhile the statelessbatchMatchdoes not. Also thestateis only passed down to the Trie build functionModifications
Remove the dead stateless
Ngram::batchMatchcode.Accuracy Tests
N/A
Speed Tests and Profiling
N/A
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci