Fix SWA eviction boundary and page-align chunked prefill#22470
Merged
Fix SWA eviction boundary and page-align chunked prefill#22470
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
ispobock
approved these changes
Apr 10, 2026
Collaborator
Author
|
/rerun-test test_swa_eviction_boundary.py |
Contributor
|
✅ |
Collaborator
Author
|
/rerun-test test_swa_eviction_boundary.py |
Contributor
|
✅ |
Collaborator
Author
|
/tag-and-rerun-ci |
Collaborator
Author
|
/rerun-test test_swa_eviction_boundary.py test_swa_unittest.py test_swa_radix_cache_kl.py |
Contributor
|
✅ |
Fridge003
pushed a commit
that referenced
this pull request
Apr 11, 2026
pyc96
pushed a commit
to pyc96/sglang
that referenced
this pull request
Apr 14, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SWA radix tree insert boundary bug when
page_size > sliding_window_size:_evict_swacould over-evict to exactlypage_floor(seq_len), making all tokens being inserted fully evicted (case 3)_insert_helperhad no handling for case 3 (swa_evicted_seqlen == total_length), falling through to_add_new_node(swa_tombstone=False)for already-evicted tokensswa_evictable_size_, caused negative usage, and led to potential double-free on subsequent tree evictionTwo-sided fix:
page_sizein_evict_swaformula so the frontier never reaches the insert boundary_insert_helperfor case 3 (free value, don't create node)Test plan
/rerun-test test_swa_eviction_boundary.py/rerun-test test_swa_unittest.py/rerun-test test_swa_radix_cache_kl.py