Skip to content

[Test] Add CPU unit tests for MemoryPoolConfigurator#22420

Merged
hnyls2002 merged 13 commits into
mainfrom
lsyin/pool-configurator-test
Apr 9, 2026
Merged

[Test] Add CPU unit tests for MemoryPoolConfigurator#22420
hnyls2002 merged 13 commits into
mainfrom
lsyin/pool-configurator-test

Conversation

@hnyls2002
Copy link
Copy Markdown
Collaborator

Summary

  • Add CPU-only unit tests for DefaultPoolConfigurator and HybridSWAPoolConfigurator
  • Mock ModelRunner to test computation logic without GPU
  • Verify memory utilization (used > 99% of available), page alignment, ratio correctness, and constraint behavior
  • Cover hybrid SWA, all-SWA, and default (MHA) paths

Follows up on #22389.

Test plan

  • /rerun-test test_pool_configurator.py

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@hnyls2002
Copy link
Copy Markdown
Collaborator Author

hnyls2002 commented Apr 9, 2026

/rerun-test test_pool_configurator.py

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

ubuntu-latest (1 test): View workflow run

cd test/ && python3 registered/unit/model_executor/test_pool_configurator.py

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

ubuntu-latest (1 test): View workflow run

cd test/ && python3 registered/unit/model_executor/test_pool_configurator.py

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

ubuntu-latest (1 test): View workflow run

cd test/ && python3 registered/unit/model_executor/test_pool_configurator.py

Base automatically changed from lsyin/pool-configurator-v2 to main April 9, 2026 07:29
@ispobock
Copy link
Copy Markdown
Collaborator

ispobock commented Apr 9, 2026

/rerun-test test_pool_configurator.py

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

ubuntu-latest (1 test): View workflow run

cd test/ && python3 registered/unit/model_executor/test_pool_configurator.py

@hnyls2002 hnyls2002 merged commit 8ff01d6 into main Apr 9, 2026
61 of 67 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/pool-configurator-test branch April 9, 2026 07:39
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants