[fix] [whisper] ensure inputs are moved to the correct device before processing.#22293
Merged
yhyang201 merged 3 commits intosgl-project:mainfrom Apr 8, 2026
Merged
Conversation
…device before processing.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
yhyang201
approved these changes
Apr 8, 2026
Collaborator
|
/tag-and-rerun-ci |
2 tasks
yhyang201
approved these changes
Apr 8, 2026
mickqian
approved these changes
Apr 8, 2026
| position_ids: torch.Tensor, | ||
| forward_batch: ForwardBatch, | ||
| ): | ||
| device = self.conv1.weight.device |
Collaborator
There was a problem hiding this comment.
nit: device=next(self()).device is more robust
2 tasks
JustinTong0323
added a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 8, 2026
Cherry-picked from sgl-project#22293. Ensures input features and position IDs are moved to the correct device before encoder processing.
JustinTong0323
added a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 8, 2026
Cherry-picked from sgl-project#22293. Ensures input features and position IDs are moved to the correct device before encoder processing.
Collaborator
|
all cuda ci passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Whisper was not covered by the Lazy device transfer introduced by #22038 , thus caused a bug that the input features may not be transferred to the correct device.
Can be spotted by the manual test here: https://github.com/sgl-project/sglang/blob/main/test/manual/test_whisper_cuda_graph.py
main branch
this PR
everything good
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci