[fix] Fix writer lock deadlock in update_weights_from_ipc during pause_generation - #22290
Merged
hnyls2002 merged 2 commits intoApr 8, 2026
Conversation
…e_generation When the scheduler is paused, existing readers are blocked on is_pause_cond, so acquiring the writer lock would deadlock. Skip the writer lock when paused (using nullcontext()) since no concurrent inference can race in that state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maocheng23
requested review from
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
April 7, 2026 22:59
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
/rerun-test test_scheduler_pause_generation.py test_pause_generation_tensor_consistency.py test_update_weights_from_tensor.py test_update_weights_from_distributed.py |
Contributor
|
✅ ✅ ✅ |
carlosfundora
pushed a commit
to carlosfundora/sglang-1-bit-turbo
that referenced
this pull request
Apr 8, 2026
…s_from_ipc during pause_generation (sgl-project#22290) Upstream SHA: 6c2a759 Cherry-picked from sgl-project/sglang Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
caitengwei
pushed a commit
to caitengwei/sglang
that referenced
this pull request
Jun 1, 2026
…e_generation (sgl-project#22290) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
…e_generation (sgl-project#22290) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_weights_from_ipcwhen scheduler is inpause_generationmodeis_pause_cond, so acquiring the writer lock would deadlock. This change skips the writer lock when paused (usingnullcontext()) since no concurrent inference can race in that state.Test plan
🤖 Generated with Claude Code