[AMD][CI] Add Gemma 4 nightly accuracy tests for MI30x and MI35x - #22201
Closed
michaelzhang-ai wants to merge 4 commits into
Closed
[AMD][CI] Add Gemma 4 nightly accuracy tests for MI30x and MI35x#22201michaelzhang-ai wants to merge 4 commits into
michaelzhang-ai wants to merge 4 commits into
Conversation
michaelzhang-ai
requested review from
Fridge003,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
April 6, 2026 19:33
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces accuracy evaluation tests for Gemma 4 models on AMD MI300X/MI325 and MI35x platforms using the mgsm_en benchmark. The review feedback highlights several improvement opportunities, including refactoring the tests to eliminate code duplication between the two new files, extracting common configuration arguments into constants to improve maintainability, and adopting a more idiomatic approach for passing evaluation arguments by using types.SimpleNamespace instead of the type() constructor.
michaelzhang-ai
requested review from
AniZpZ,
BBuf,
CatherineSue,
Edwardf0t1,
FlamingoPg,
HaiShaw,
JustinTong0323,
Qiaolin-Yu,
Ying1123,
b8zhong,
ch-wan,
hanming-lu,
hebiao064,
hnyls2002,
hzh0425,
mickqian,
slin1237,
xiezhq-hermann,
yhyang201,
yizhang2077 and
yuan-luo
as code owners
April 6, 2026 19:38
michaelzhang-ai
force-pushed
the
add-gemma4-amd-accuracy-test
branch
from
April 13, 2026 06:22
b1a5218 to
fc8468d
Compare
This was referenced Apr 22, 2026
This was referenced Apr 29, 2026
DavidBellamy
added a commit
to LLM360/sglang
that referenced
this pull request
May 5, 2026
Patches 9 files (mooncake disaggregation, mooncake transfer engine,
HTTP server, OpenAI protocol/serving_chat, server_args, sgl-model-gateway
router/server, plus test fixture) to apply the agentic-rl runtime
modifications statically, instead of `git apply`-ing at Docker build time.
Source: LLM360/RL360 patches/agentic-rl/sglang.patch
@ f34aa3b166c0a2466df9b38fd5f8be9ff78e2dae
This was referenced May 5, 2026
This was referenced May 14, 2026
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add nightly accuracy test for Gemma 4 on AMD MI30x (MI325/MI300X), matching AMD Day 0 support announcement.
Changes
New test file
test/registered/amd/accuracy/mi30x/test_gemma4_eval_amd.pyModel tested
google/gemma-4-31B-itServer configuration
--attention-backend triton(required for bidirectional image-token attention on AMD)--watchdog-timeout 1200(for first-time weight download)transformersfrom the commit required by [New Model] Gemma 4 #21952Workflow integration
Gemma 4 test added as a step (not a standalone job) inside the existing
nightly-accuracy-2-gpujob in both workflows:nightly-test-amd.yml— step: "Accuracy Test (Gemma 4)"nightly-test-amd-rocm720.yml— step: "Accuracy Test ROCm 7.2 (Gemma 4)"Step uses
if: always()so it runs even if the prior GSM8K step fails.CI Results
Test plan
if: always()confirmed working — Gemma 4 step passed despite prior step failure