Skip to content

[AMD][CI] Add Gemma 4 nightly accuracy tests for MI30x and MI35x - #22201

Closed
michaelzhang-ai wants to merge 4 commits into
mainfrom
add-gemma4-amd-accuracy-test
Closed

[AMD][CI] Add Gemma 4 nightly accuracy tests for MI30x and MI35x#22201
michaelzhang-ai wants to merge 4 commits into
mainfrom
add-gemma4-amd-accuracy-test

Conversation

@michaelzhang-ai

@michaelzhang-ai michaelzhang-ai commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Add nightly accuracy test for Gemma 4 on AMD MI30x (MI325/MI300X), matching AMD Day 0 support announcement.

Changes

New test file

  • test/registered/amd/accuracy/mi30x/test_gemma4_eval_amd.py

Model tested

Model Architecture TP mgsm_en Threshold Observed Score
google/gemma-4-31B-it Dense 31B 1 0.90 0.984

Server configuration

  • --attention-backend triton (required for bidirectional image-token attention on AMD)
  • --watchdog-timeout 1200 (for first-time weight download)
  • Step installs transformers from the commit required by [New Model] Gemma 4 #21952

Workflow integration

Gemma 4 test added as a step (not a standalone job) inside the existing nightly-accuracy-2-gpu job in both workflows:

  • nightly-test-amd.yml — step: "Accuracy Test (Gemma 4)"
  • nightly-test-amd-rocm720.yml — step: "Accuracy Test ROCm 7.2 (Gemma 4)"

Step uses if: always() so it runs even if the prior GSM8K step fails.

CI Results

Run Platform Result
Run 7 MI30x (default ROCm) ✅ pass
Run 7 MI35x (default ROCm) ✅ pass
Run 8 MI30x (ROCm 7.2) ✅ pass
Run 8 MI35x (ROCm 7.2) ✅ pass

Test plan

  • YAML validation passes locally
  • Single commit, 3 files changed (2 workflow edits + 1 test file)
  • Gemma 4 accuracy verified: 0.984 on MI30x (threshold 0.90)
  • if: always() confirmed working — Gemma 4 step passed despite prior step failure
  • Passed on all 4 platform/ROCm combinations

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces accuracy evaluation tests for Gemma 4 models on AMD MI300X/MI325 and MI35x platforms using the mgsm_en benchmark. The review feedback highlights several improvement opportunities, including refactoring the tests to eliminate code duplication between the two new files, extracting common configuration arguments into constants to improve maintainability, and adopting a more idiomatic approach for passing evaluation arguments by using types.SimpleNamespace instead of the type() constructor.

Comment thread test/registered/amd/accuracy/mi30x/test_gemma4_eval_amd.py
Comment thread test/registered/amd/accuracy/mi30x/test_gemma4_eval_amd.py
Comment thread test/registered/amd/accuracy/mi30x/test_gemma4_eval_amd.py
Comment thread test/registered/amd/accuracy/mi35x/test_gemma4_eval_mi35x.py Outdated
Comment thread test/registered/amd/accuracy/mi35x/test_gemma4_eval_mi35x.py Outdated
@michaelzhang-ai
michaelzhang-ai force-pushed the add-gemma4-amd-accuracy-test branch from b1a5218 to fc8468d Compare April 13, 2026 06:22
DavidBellamy added a commit to LLM360/sglang that referenced this pull request May 5, 2026
Patches 9 files (mooncake disaggregation, mooncake transfer engine,
HTTP server, OpenAI protocol/serving_chat, server_args, sgl-model-gateway
router/server, plus test fixture) to apply the agentic-rl runtime
modifications statically, instead of `git apply`-ing at Docker build time.

Source: LLM360/RL360 patches/agentic-rl/sglang.patch
        @ f34aa3b166c0a2466df9b38fd5f8be9ff78e2dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amd Multi-modal multi-modal language model quant LLM Quantization run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants