[CI] Remove stale ascend entries from run_suite.py#21916
Closed
Godmook wants to merge 1 commit intosgl-project:mainfrom
Closed
[CI] Remove stale ascend entries from run_suite.py#21916Godmook wants to merge 1 commit intosgl-project:mainfrom
Godmook wants to merge 1 commit intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
@huaiyuzh please take a look |
Contributor
Author
|
@airMeng I'll close both PRs. Thanks for helping to fix CIs. I'm so excited about that! |
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #20751 moved all ascend tests from
test/srt/ascend/totest/registered/ascend/but did not remove the old entries fromsuite_ascendintest/srt/run_suite.py. Since_sanity_check_suites()validates all suites globally before running any--suite, this breaks every non-ascend suite too (XPU, Xeon, etc.).Example:
Modifications
TestFile(...)entries fromsuite_ascendthat reference files no longer on disk.ascend/test_embed_interpolate_unittest.pywhich still exists undertest/srt/ascend/.Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci