Skip to content

[CI] Remove stale ascend entries from run_suite.py#21916

Closed
Godmook wants to merge 1 commit intosgl-project:mainfrom
Godmook:fix/ascend-suite-stale-entries1
Closed

[CI] Remove stale ascend entries from run_suite.py#21916
Godmook wants to merge 1 commit intosgl-project:mainfrom
Godmook:fix/ascend-suite-stale-entries1

Conversation

@Godmook
Copy link
Copy Markdown
Contributor

@Godmook Godmook commented Apr 2, 2026

Motivation

PR #20751 moved all ascend tests from test/srt/ascend/ to test/registered/ascend/ but did not remove the old entries from suite_ascend in test/srt/run_suite.py. Since _sanity_check_suites() validates all suites globally before running any --suite, this breaks every non-ascend suite too (XPU, Xeon, etc.).

Example:

DEPRECATION NOTICE: The folder `test/srt` should be deprecated as soon as possible. Migrate tests to the new CI registry system described in `test/README.md`.
args=Namespace(timeout_per_file=1200, suite='per-commit-xpu', auto_partition_id=None, auto_partition_size=None, continue_on_error=False, enable_retry=False, max_attempts=2, retry_wait_seconds=60, retry_timeout_increase=600)
Traceback (most recent call last):
  File "/home/sdp/sglang/test/srt/run_suite.py", line 336, in <module>
    main()
  File "/home/sdp/sglang/test/srt/run_suite.py", line 276, in main
    _sanity_check_suites(suites)
  File "/home/sdp/sglang/test/srt/run_suite.py", line 196, in _sanity_check_suites
    len(nonexistent_files) == 0
AssertionError: Some test files in test suite do not exist on disk:
TestFile("ascend/test_ascend_autoround_dense.py"),
TestFile("ascend/test_ascend_autoround_moe.py"),
TestFile("ascend/test_ascend_compile_graph_tp1_bf16.py"),
TestFile("ascend/test_ascend_deepep.py"),
TestFile("ascend/test_ascend_gptq_moe.py"),
TestFile("ascend/test_ascend_graph_tp1_bf16.py"),
TestFile("ascend/test_ascend_graph_tp2_bf16.py"),
TestFile("ascend/test_ascend_hicache_mha.py"),
TestFile("ascend/test_ascend_hicache_mla.py"),
TestFile("ascend/test_ascend_mla_fia_w8a8int8.py"),
TestFile("ascend/test_ascend_mla_w8a8int8.py"),
TestFile("ascend/test_ascend_piecewise_graph_prefill.py"),
TestFile("ascend/test_ascend_sampling_backend.py"),
TestFile("ascend/test_ascend_tp1_bf16.py"),
TestFile("ascend/test_ascend_tp2_bf16.py"),
TestFile("ascend/test_ascend_tp2_fia_bf16.py"),
TestFile("ascend/test_ascend_tp4_bf16.py"),
TestFile("ascend/test_ascend_w4a4_quantization.py"),
TestFile("ascend/test_ascend_w8a8_quantization.py"),
TestFile("ascend/test_llada2_mini_ascend.py"),
Error: Process completed with exit code 1.

Modifications

  • Removed 20 stale TestFile(...) entries from suite_ascend that reference files no longer on disk.
  • Kept ascend/test_embed_interpolate_unittest.py which still exists under test/srt/ascend/.

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@Godmook Godmook mentioned this pull request Apr 2, 2026
5 tasks
@airMeng
Copy link
Copy Markdown
Collaborator

airMeng commented Apr 3, 2026

@huaiyuzh please take a look

@Godmook
Copy link
Copy Markdown
Contributor Author

Godmook commented Apr 3, 2026

@airMeng I'll close both PRs. Thanks for helping to fix CIs. I'm so excited about that!

@Godmook Godmook closed this Apr 3, 2026
@Godmook
Copy link
Copy Markdown
Contributor Author

Godmook commented Apr 3, 2026

#21978 @airMeng @huaiyuzh It has been fixed from this PR! :)

@Godmook Godmook deleted the fix/ascend-suite-stale-entries1 branch April 5, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants