-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[CI] add nvfp4 ci test for b200; #21767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ea95b7
[CI] add nvfp4 ci test for b200;
Prozac614 6c3028d
[CI] run perf test
Prozac614 12d8508
[CI] follow gemini's suggestion
Prozac614 acd4ab7
Merge branch 'main' into ci/nvfp4_B200
Prozac614 7a1e09b
[CI] avoid fast fail
Prozac614 8a69e72
upd
mickqian 6ffa5d2
Merge remote-tracking branch 'origin/main' into ci/nvfp4_B200
mickqian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| """ | ||
| Config-driven diffusion performance test with pytest parametrization. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
|
|
||
| from sglang.multimodal_gen.runtime.utils.logging_utils import init_logger | ||
| from sglang.multimodal_gen.test.server.test_server_common import ( # noqa: F401 | ||
| DiffusionServerBase, | ||
| diffusion_server, | ||
| ) | ||
| from sglang.multimodal_gen.test.server.testcase_configs import ( | ||
| ONE_GPU_CASES_C, | ||
| DiffusionTestCase, | ||
| ) | ||
|
|
||
| logger = init_logger(__name__) | ||
|
|
||
|
|
||
| class TestDiffusionServerOneGpuB200(DiffusionServerBase): | ||
| """B200-targeted smoke tests for 1-GPU diffusion cases.""" | ||
|
|
||
| @pytest.fixture(params=ONE_GPU_CASES_C, ids=lambda c: c.id) | ||
| def case(self, request) -> DiffusionTestCase: | ||
| """Provide a DiffusionTestCase for each 1-GPU B200 test.""" | ||
| return request.param |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -798,7 +798,7 @@ def from_req_perf_record( | |
| ) | ||
| ) | ||
|
|
||
| # TODO: enable on 4090/5090/b200 | ||
| # TODO: enable on 4090/5090 | ||
| ONE_GPU_CASES_C = [ | ||
| DiffusionTestCase( | ||
| "flux_2_nvfp4_t2i", | ||
|
|
@@ -807,6 +807,7 @@ def from_req_perf_record( | |
| modality="image", | ||
| ), | ||
| T2I_sampling_params, | ||
| run_perf_check=False, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should enable this
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, I'll enable this |
||
| ) | ||
| ] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and consistency with
run_suite.py, uselist(SUITES.keys())for thechoicesargument and a generic help message. This avoids the need to manually update this script whenever a new test suite is added to the system.