Skip to content

[Feature] JIT activation and update skills (by codex)#21766

Merged
DarkSharpness merged 4 commits intosgl-project:mainfrom
DarkSharpness:jit_act
Apr 3, 2026
Merged

[Feature] JIT activation and update skills (by codex)#21766
DarkSharpness merged 4 commits intosgl-project:mainfrom
DarkSharpness:jit_act

Conversation

@DarkSharpness
Copy link
Copy Markdown
Collaborator

Motivation

Modifications

Accuracy Tests

Speed Tests and Profiling

(TL;DR: Performance gain is mostly from PDL and vectorization)

H200:

image

B200:

image

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@DarkSharpness
Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces JIT-compiled activation kernels (SiLU, GELU, and GELU-Tanh with multiplication) to replace AOT implementations on CUDA platforms. The changes include the core CUDA kernel implementation, Python wrappers, unit tests, and benchmarks. Documentation is also updated to include guidance on JIT kernel development and the new PDL (Primary-to-Secondary Dependency Link) feature. Review feedback identifies a missing import for the HIP platform in the multimodal runtime and points out an incorrect output shape registration in the custom operator metadata for activations.

DarkSharpness and others added 2 commits April 2, 2026 12:38
Co-authored-by: weiminc <tnwilly@gmail.com>
@DarkSharpness DarkSharpness merged commit 44e5d35 into sgl-project:main Apr 3, 2026
150 of 186 checks passed
@DarkSharpness DarkSharpness deleted the jit_act branch April 3, 2026 15:28
@DarkSharpness DarkSharpness mentioned this pull request Apr 3, 2026
5 tasks
@Fridge003
Copy link
Copy Markdown
Collaborator

Hi @DarkSharpness, this PR was reverted due to this failure https://github.com/sgl-project/sglang/actions/runs/23958698449/job/69895069178?pr=21913
Please help relanding later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion documentation Improvements or additions to documentation jit-kernel lora run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants