[Fix] Add timeout and retry to MGSM data download to prevent CI timeout#21732
Closed
[Fix] Add timeout and retry to MGSM data download to prevent CI timeout#21732
Conversation
The test_moe_eval_accuracy_large.py test_mgsm_en has been consistently timing out in CI because urllib.request.urlopen() had no timeout when downloading MGSM benchmark data from openaipublic.blob.core.windows.net. When the download hangs, the test hangs indefinitely until the 1200s CI timeout kills it, with zero inference requests reaching the server. Add a 60s timeout and 3 retries with exponential backoff. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-ut test_moe_ep.py |
Contributor
|
✅ |
Collaborator
Author
|
/rerun-ut test_moe_eval_accuracy_large.py |
Contributor
|
✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_moe_eval_accuracy_large.py::test_mgsm_enhas been consistently timing out in CI since ~Mar 30 12:00 UTCurllib.request.urlopen()insimple_eval_mgsm.py:get_lang_examples()has no timeout when downloading MGSM benchmark data fromopenaipublic.blob.core.windows.net. When the download hangs (network issue from CI runners), the test hangs indefinitely until the 1200s CI timeout kills it62a63eeff) and first fail (b76730701) don't touch inference code for MixtralChanges
timeout=60tourllib.request.urlopen()callurllib.errorandurllib.requestimportsTest plan
test_moe_eval_accuracy_largepasses (if blob storage is reachable) or fails fast with a clear error (if not)🤖 Generated with Claude Code