[CI] Register jit_kernel Test Files to Solve No Registry Found Error#21541
[CI] Register jit_kernel Test Files to Solve No Registry Found Error#21541
Conversation
bingxche
requested review from
BBuf,
DarkSharpness,
HydraQYH,
celve and
yuan-luo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates JIT kernel benchmarks and unit tests into the CUDA CI pipeline by adding registration calls. The review feedback identifies that the disabled parameter should be removed from these new registrations since estimated execution times are now provided, ensuring the tests actually run during CI.
| register_cuda_ci( | ||
| est_time=13, | ||
| suite="stage-b-kernel-benchmark-1-gpu-large", | ||
| disabled="unknown est_time", | ||
| ) |
There was a problem hiding this comment.
The disabled parameter will cause this test to be registered but skipped by the CI. Since an est_time is provided and the goal of this PR is to enable these tests, the disabled parameter should be removed.
register_cuda_ci(
est_time=13,
suite="stage-b-kernel-benchmark-1-gpu-large",
)| register_cuda_ci( | ||
| est_time=17, | ||
| suite="stage-b-kernel-benchmark-1-gpu-large", | ||
| disabled="unknown est_time", | ||
| ) |
There was a problem hiding this comment.
The disabled parameter will cause this test to be registered but skipped by the CI. Since an est_time is provided and the goal of this PR is to enable these tests, the disabled parameter should be removed.
register_cuda_ci(
est_time=17,
suite="stage-b-kernel-benchmark-1-gpu-large",
)| register_cuda_ci( | ||
| est_time=24, | ||
| suite="stage-b-kernel-unit-1-gpu-large", | ||
| disabled="unknown est_time", | ||
| ) | ||
| register_cuda_ci( | ||
| est_time=120, | ||
| suite="nightly-kernel-1-gpu", | ||
| nightly=True, | ||
| disabled="unknown est_time", | ||
| ) |
There was a problem hiding this comment.
The disabled parameter will cause these tests to be registered but skipped by the CI. Since an est_time is provided for both and the goal of this PR is to enable these tests, the disabled parameter should be removed from both register_cuda_ci calls.
register_cuda_ci(
est_time=24,
suite="stage-b-kernel-unit-1-gpu-large",
)
register_cuda_ci(
est_time=120,
suite="nightly-kernel-1-gpu",
nightly=True,
)| register_cuda_ci( | ||
| est_time=64, | ||
| suite="stage-b-kernel-unit-1-gpu-large", | ||
| disabled="unknown est_time", | ||
| ) | ||
| register_cuda_ci( | ||
| est_time=256, | ||
| suite="nightly-kernel-1-gpu", | ||
| nightly=True, | ||
| disabled="unknown est_time", | ||
| ) |
There was a problem hiding this comment.
The disabled parameter will cause these tests to be registered but skipped by the CI. Since an est_time is provided for both and the goal of this PR is to enable these tests, the disabled parameter should be removed from both register_cuda_ci calls.
register_cuda_ci(
est_time=64,
suite="stage-b-kernel-unit-1-gpu-large",
)
register_cuda_ci(
est_time=256,
suite="nightly-kernel-1-gpu",
nightly=True,
)
|
Issue already solved |
2 participants
Motivation
#21538
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci