Skip to content

[AMD] Fix Handle missing rope_theta in get_rope_config for Grok-1 #21518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaiShaw merged 2 commits into from
Mar 31, 2026
Merged

[AMD] Fix Handle missing rope_theta in get_rope_config for Grok-1 #21518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135db31
[Fix] Handle missing rope_theta in Grok-1 config
michaelzhang-ai Mar 27, 2026
be4649e
Merge branch 'main' into fix/grok1-rope-theta-fallback
yctseng0211 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/sglang/srt/models/grok.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
from sglang.srt.model_loader.loader import DefaultModelLoader
from sglang.srt.model_loader.weight_utils import default_weight_loader
from sglang.srt.utils import add_prefix, is_npu
from sglang.srt.utils.hf_transformers_utils import get_rope_config

_is_npu = is_npu()

Expand Down Expand Up @@ -478,7 +477,10 @@ def __init__(
self.layer_id = layer_id
self.alt_stream = alt_stream or torch.cuda.Stream()

rope_theta, _ = get_rope_config(config)
rope_theta = getattr(config, "rope_theta", None)
if rope_theta is None:
rope_params = getattr(config, "rope_parameters", None)
rope_theta = rope_params["rope_theta"] if rope_params else 10000
self.self_attn = Grok1Attention(
config=config,
hidden_size=self.hidden_size,
Expand Down
Loading