Fixed the IPV6 socket issue in encode server of EPD#21493
Open
hhzguo wants to merge 2 commits intosgl-project:mainfrom
Open
Fixed the IPV6 socket issue in encode server of EPD#21493hhzguo wants to merge 2 commits intosgl-project:mainfrom
hhzguo wants to merge 2 commits intosgl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces IPv6 support for ZMQ communication and refactors network address handling using the NetworkAddress utility. It also adds error handling for socket operations in the encode_server. A critical issue was identified where exceptions in the socket sending logic are caught and logged but not re-raised, which could lead to silent data loss and make debugging difficult.
c8e680b to
7bd5d75
Compare
Collaborator
|
Maybe covered in #21236? |
Contributor
Author
partially. You may ask the owner of 21236 to merge the change in network.py to his/her and I will close mine. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When run EPD on node with IPV6 address, the zmq for IPV6 has the following issues:
1 ipv6 address is not handled correctly in get_zmq_socket_host function if host is none
2 encode server doesn't handle IPV6, which causes the communication problems between encode server and prefill server
Modifications
add zmq.IPV6 to socket
Accuracy Tests
lm-eval run result:

Benchmarking and Profiling
The change doesn't impact the performance.
But I post the benchmark result here for ref.
1 encode server, 1 prefill and 1 decode on the same h200 node.
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci