Remove redundant DeepSeek V3 FP4 PCG test#21485
Merged
Fridge003 merged 1 commit intosgl-project:mainfrom Mar 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the estimated execution time for the DeepSeek-V3 FP4 4-GPU test suite and removes the TestDeepseekV3FP4PiecewiseCudaGraph test class. It also refactors the test_bs_1_speed method to use an underscore for an unused variable. I have no feedback to provide.
Fridge003
approved these changes
Mar 27, 2026
Fridge003
pushed a commit
that referenced
this pull request
Mar 27, 2026
satyamk7054
pushed a commit
to satyamk7054/sglang
that referenced
this pull request
Apr 3, 2026
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PCG is now enabled by default.
TestDeepseekV3FP4PiecewiseCudaGraphruns the exact same config asTestDeepseekV3FP4(both use default PCG) and is wasting CI time and resources.cc @Fridge003 @Kangyan-Zhou