Skip to content

[bugfix] Fix rope theta config for MiniMax after transformers v5 update #21241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fridge003 merged 1 commit into from
Mar 31, 2026
+3 −3
Merged

[bugfix] Fix rope theta config for MiniMax after transformers v5 update #21241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/sglang/srt/models/minimax_m2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
is_non_idle_and_non_empty,
make_layers,
)
from sglang.srt.utils.hf_transformers_utils import get_rope_config

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -570,7 +571,7 @@ def __init__(

# RoPE settings - support partial RoPE
# FIXME: minimax_m2 config use external config that not compatible with transformers v5
self.rope_theta = config.rope_theta
self.rope_theta, self.rope_scaling = get_rope_config(config)
self.max_position_embeddings = getattr(config, "max_position_embeddings", 8192)
self.rotary_dim = getattr(
config, "rotary_dim", self.head_dim
Expand Down Expand Up @@ -600,13 +601,12 @@ def __init__(
)

# Setup RoPE with partial rotary dimension
rope_scaling = getattr(config, "rope_scaling", None)
self.rotary_emb = get_rope(
self.head_dim,
rotary_dim=self.rotary_dim, # Use partial rotary dimension
max_position=self.max_position_embeddings,
base=self.rope_theta,
rope_scaling=rope_scaling,
rope_scaling=self.rope_scaling,
)

# QK Normalization layers
Expand Down
Loading