[Spec][Ngram] 2/N: Rename branch length to max trie depth#21181
Merged
hnyls2002 merged 10 commits intosgl-project:mainfrom Mar 23, 2026
Merged
[Spec][Ngram] 2/N: Rename branch length to max trie depth#21181hnyls2002 merged 10 commits intosgl-project:mainfrom
hnyls2002 merged 10 commits intosgl-project:mainfrom
Conversation
- Rename module/extension (ngram_corpus_cpp), sources, and TrieCache→Trie - Update ngram_worker and registered tests Made-with: Cursor
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kpham-sgl
requested review from
Ying1123,
hnyls2002 and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
bot
added
documentation
9 tasks
Collaborator
Author
|
/tag-and-rerun-ci |
kpham-sgl
changed the title
kpham-sgl
changed the title
5 tasks
0-693
pushed a commit
to 0-693/sglang
that referenced
this pull request
Mar 25, 2026
…t#21181) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of Ngram refactoring series
Modifications
Rename
branch-lengthtomax-trie-depthAccuracy Tests
Passed
python -m pytest test/registered/spec/utils/test_ngram_corpus.pyBenchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci