Skip to content

[Bugifx] qwen3 rope parameter compatibility #20931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fridge003 merged 3 commits into from
Mar 20, 2026
+4 −3
Merged

[Bugifx] qwen3 rope parameter compatibility #20931

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
973893f
fix: qwen3 rope parameter compatibility
lviy Mar 19, 2026
0fe3763
Update python/sglang/srt/models/qwen3_moe.py
lviy Mar 19, 2026
30e6cd3
Refactor: use get_rope_config utility instead of inline rope parsing
JustinTong0323 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/sglang/srt/models/qwen3_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
is_non_idle_and_non_empty,
is_npu,
)
from sglang.srt.utils.hf_transformers_utils import get_rope_config

_is_cuda = is_cuda()

Expand Down Expand Up @@ -566,7 +567,7 @@ def forward_prepare_native(
def apply_qk_norm_rope(self, qkv, positions, forward_batch):
use_fused = self.use_fused_qk_norm_rope and qkv.dtype == torch.bfloat16
if use_fused:
theta = self.config.rope_parameters["rope_theta"]
theta = self.rope_theta
positions = (
positions.view(-1).to(dtype=torch.int32, device=qkv.device).contiguous()
)
Expand Down Expand Up @@ -691,8 +692,8 @@ def __init__(
super().__init__()
self.config = config
self.hidden_size = config.hidden_size
rope_theta = config.rope_parameters["rope_theta"]
rope_scaling = config.rope_parameters
rope_theta, rope_scaling = get_rope_config(config)
self.rope_theta = rope_theta
max_position_embeddings = getattr(config, "max_position_embeddings", 8192)
head_dim = getattr(
config, "head_dim", config.hidden_size // config.num_attention_heads
Expand Down
Loading