Skip to content

[Bugfix] Fix effective_mamba_size over-allocation #20858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShangmingCai merged 7 commits into from
Apr 1, 2026
+12 −3
Merged

[Bugfix] Fix effective_mamba_size over-allocation #20858

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be3f536
[Bugfix] Fix effective_mamba_size over-allocation in HybridMambaDecod…
yunkchen Mar 18, 2026
46d7b6e
fixup code format and remove modifying pre_alloc_size
yunkchen Mar 19, 2026
7928a85
fixup whitespace
yunkchen Mar 20, 2026
dd7f147
Limit effective_mamba_size based on mamba_size
yunkchen Mar 23, 2026
f8909bf
Merge branch 'main' into fix_mamba_pool_alloc_size
ShangmingCai Mar 25, 2026
431e08d
Merge branch 'main' into fix_mamba_pool_alloc_size
ShangmingCai Mar 31, 2026
c14b600
Merge branch 'main' into fix_mamba_pool_alloc_size
ShangmingCai Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions python/sglang/srt/disaggregation/decode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,18 @@ def __init__(
self.mamba_ping_pong_track_buffer_size = 2 if enable_overlap_schedule else 1
self.enable_mamba_extra_buffer = enable_mamba_extra_buffer
self.enable_memory_saver = enable_memory_saver
effective_mamba_size = (
mamba_size if mamba_size is not None else size
) + pre_alloc_size
if mamba_size is not None:
effective_mamba_size = min(mamba_size, size + pre_alloc_size)
if mamba_size > size + pre_alloc_size:
logger.warning(
"mamba_size (%d) exceeds size + pre_alloc_size (%d), "
"capping effective_mamba_size to %d",
mamba_size,
size + pre_alloc_size,
effective_mamba_size,
)
else:
effective_mamba_size = size + pre_alloc_size
self.start_layer = start_layer if start_layer is not None else 0
self.layer_transfer_counter = None
self._init_mamba_pool(
Expand Down
Loading