[AMD] CI: stop installing transformers from git main in Qwen 3.5 and GLM-5 nightly tests#20748
Closed
michaelzhang-ai wants to merge 1 commit intosgl-project:mainfrom
Closed
Conversation
…GLM-5 nightly tests Transformers PR huggingface/transformers#41250 (merged Mar 16) converts PretrainedConfig subclasses to @DataClass via __init_subclass__, which breaks sglang's DeepseekVL2Config (non-default field ordering) and prevents the server from starting at all. Remove `pip install git+https://github.com/huggingface/transformers.git` from all Qwen 3.5 and GLM-5 CI jobs (MI30x, MI35x, ROCm 7.0 and 7.2). Use the stable transformers shipped in the docker image instead, matching all other nightly jobs (Grok2, DeepSeek-V3.2, etc.). Keep mistral-common and lm-eval[api] for Qwen 3.5 tests that need them.
michaelzhang-ai
requested review from
Fridge003,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install git+https://github.com/huggingface/transformers.gitfrom all Qwen 3.5 and GLM-5 CI jobs across bothnightly-test-amd.ymlandnightly-test-amd-rocm720.ymlmistral-commonandlm-eval[api]for Qwen 3.5 tests that need themMotivation
Transformers PR huggingface/transformers#41250 (merged Mar 16) converts
PretrainedConfigsubclasses to@dataclassvia__init_subclass__, which breaks sglang'sDeepseekVL2Config(non-default fieldvision_configfollows default arguments). This crashes the server on import and prevents any test from running:Both the Qwen 3.5 MI35x and GLM-5 MI35x jobs failed in Nightly #633 for this reason, while Grok2 and DeepSeek-V3.2 (which don't install from git main) passed fine.
Installing bleeding-edge transformers from
mainis fragile — upstream breaking changes can silently break CI at any time. The stable version in the docker image is sufficient.Test plan