fix: adding teacache.params back to sampling params as intended#20665
Merged
fix: adding teacache.params back to sampling params as intended#20665
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
mickqian
reviewed
Mar 16, 2026
Collaborator
mickqian
left a comment
There was a problem hiding this comment.
could we modify a testcase to guard this model?
Collaborator
Author
Added a teacache test for Wan2.2! |
mickqian
approved these changes
Mar 16, 2026
Collaborator
|
/tag-and-rerun-ci |
Collaborator
|
/tag-and-rerun-ci |
Collaborator
|
@mickqian All CI (Nvidia + AMD) passed and PR is approved, ready for merge — SGLDHelper bot |
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
0-693
pushed a commit
to 0-693/sglang
that referenced
this pull request
Mar 25, 2026
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, adding enable_teacache=true fails with 'Req' object has no attribute 'teacache_params'. This bug was introduced in PR #19964 which intended to remove teacache_params from the request body so fallback to sampling params to be handled, but teacache_params were not on sampling params.
Also added teacache params for Wan 2.2 using the Wan2.1 14B coefficients as a proxy so that enable_teacache actually takes effect.
Modifications
Adding teacache_params back to sampling params and added teacache_params: to class Wan2_2_Base_SamplingParams.
Accuracy Tests
wan22-teacache-test.mp4
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci