[NVIDIA] Enable fp8 flashinfer_trtllm_routed MoE for MiniMax-M2.5#20394
Open
trevor-m wants to merge 1 commit intosgl-project:mainfrom
Open
[NVIDIA] Enable fp8 flashinfer_trtllm_routed MoE for MiniMax-M2.5#20394trevor-m wants to merge 1 commit intosgl-project:mainfrom
trevor-m wants to merge 1 commit intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
d49c17a to
f8b9aae
Compare
4f0c9c8 to
1563b11
Compare
2231a2c to
b652fca
Compare
5 tasks
zianglih
reviewed
Mar 17, 2026
| ): | ||
| backend = "flashinfer_trtllm_routed" | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Can we keep routed unit tests since routed and fused are 2 separate code paths?
Contributor
|
Hi @trevor-m , the key motivation to the original explicit I believe it is better to have 2 explict backends as in my previous design:
|
zianglih
reviewed
Mar 17, 2026
0c705ef to
2ba0522
Compare
zianglih
reviewed
Mar 17, 2026
zianglih
reviewed
Mar 17, 2026
75eab54 to
619fcb8
Compare
619fcb8 to
3daf5fe
Compare
Fix circular import Fix skip autotune fix routign method cast back to fp16 fixes fixes comments restore routed flag fixes fixes
3daf5fe to
ef30d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
getattrdoesn't use the default value when the attr is set to none.Issues
Accuracy Tests
TP4
TEP4
Benchmarking and Profiling
4xGB200 Results - TP4: 9.04% speedup over default (triton) moe, TEP4: 5.48% speedup
TP4 + flashinfer_trtllm moe
TP4 + default moe
TEP4 + flashinfer_trtllm_routed moe
TEP4 + default moe
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci