[Bugfix] Work around FlashInfer unified transport issue on GB#20039
[Bugfix] Work around FlashInfer unified transport issue on GB#20039Fridge003 merged 3 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a critical bug fix to prevent data corruption and incorrect outputs when using FlashInfer's unified allreduce-fusion workspace on specific NVIDIA GB series GPUs (GB200/GB300). It achieves this by implementing a temporary, platform-aware workaround that forces the use of PosixFD transport for symmetric-memory handle exchange, bypassing a known issue with Fabric handle exchange on these systems. The change improves the stability and reliability of FlashInfer operations on affected hardware. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary workaround for an issue with FlashInfer's unified transport on Grace Blackwell systems, which was causing incorrect outputs. The fix involves forcing the use of PosixFD transport by monkey-patching flashinfer.comm.mnnvl.is_mnnvl_fabric_supported when running on aarch64 architecture with SM 10.x GPUs. The changes are well-contained within a context manager to ensure the patch is applied only when needed and is properly reverted. My review focuses on improving the robustness of the exception handling. Overall, this is a good and necessary fix.
|
/rerun-failed-ci |
|
Maybe #12787 can tackle this issue with newly added mnnvl backend |
|
/rerun-stage stage-b-test-large-2-gpu |
|
✅ Triggered |
|
Hi @mmangkad @Fridge003 @JustinTong0323, may I ask when can this PR be merged? We also meet this problem on the same GB300 device, and this PR can fix it. But only use the mnnvl backend in 12787 cannot fix this problem. Thank you! |
61cc227 to
06e1220
Compare
Summary
Fix #19884
This adds a temporary workaround for incorrect outputs on GB by forcing PosixFD transport for FlashInfer’s unified allreduce-fusion workspace path until the transport issue is fixed
@Fridge003 @JustinTong0323