[VLM] Support cos sin cache for Ernie4.5-VL#19743
Merged
BBuf merged 1 commit intosgl-project:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
BBuf
approved these changes
Mar 3, 2026
Collaborator
Author
|
/rerun-failed-ci |
1 similar comment
Collaborator
Author
|
/rerun-failed-ci |
Kangyan-Zhou
pushed a commit
to Kangyan-Zhou/sglang
that referenced
this pull request
Mar 4, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
qeternity
pushed a commit
to qeternity/sglang
that referenced
this pull request
Mar 6, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
magicYang1573
pushed a commit
to magicYang1573/sglang
that referenced
this pull request
Mar 9, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR refactors the rotary positional embedding implementation to expose an explicit cos/sin cache interface and reuse it in the 2D vision RoPE code path. Instead of recomputing frequencies and calling cos() / sin() repeatedly, we precompute and cache the 1D cos/sin values once, then index into this cache for both text RoPE and the 2D grid RoPE used by the vision encoder.
The framework has already been implemented in #15205 , this PR is to enforce this enhancement into more VLMs.
Performance improved TTFT 3%.
Modifications
Accuracy Tests
lmms_eval no drops:
Main:
PR:
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci