Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request migrates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the kimi_k2_moe_fused_gate kernel to the JIT framework, which is a good step towards kernel slimming. The changes include the ported CUDA kernel, a Python wrapper, unit tests, and benchmarks. The code is well-structured and the implementation seems correct. The new JIT kernel is properly integrated, and the tests provide good coverage.
I have one suggestion to improve the robustness of the reference implementation in the unit tests to avoid potential NaN values during division by zero, ensuring the tests are reliable under all conditions.
82b5c39 to
faacb87
Compare
faacb87 to
d62a4d9
Compare
Port the large_token kernel (m > 512) from AOT to JIT with: - Vectorized float4 loads (6 tokens/block, 1 warp/token) - Runtime dispatch: small_token (m <= 512) vs large_token (m > 512) - Extended tests to cover m=512, 1024, 2048
|
Thanks @xingsy97! This migration has already landed - |
Motivation
Migrate
kimi_k2_moe_fused_gatekernel to JIT compilation (#17865).Modifications
Under
python/sglang/jit_kernel/:csrc/moe/kimi_k2_moe_fused_gate.cuh— CUDA kernel (ported fromsgl-kernel/csrc/moe/kimi_k2_moe_fused_gate.cu, both small_token and large_token variants)kimi_k2_moe_fused_gate.py— Python wrappertests/test_kimi_k2_moe_fused_gate.py— Unit tests (JIT vs PyTorch)benchmark/bench_kimi_k2_moe_fused_gate.py— Benchmark (JIT vs AOT)And
python/sglang/srt/layers/moe/topk.py— Switch import to JITAccuracy Tests
Pass all tests defined in
python/sglang/jit_kernel/tests/test_kimi_k2_moe_fused_gate.pyBenchmarking and Profiling
Both small_token (m <= 512) and large_token (m > 512) kernel variants are ported; no regression observed.
Checklist