Revert "[Blackwell] Make mxint4 flashinfer_trtllm moe gemm set by default on blackwell"#19695
Conversation
…ault on …" This reverts commit 894e887.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undoes a recent modification that introduced an automatic configuration for the MoE runner backend based on specific int4 quantization parameters for certain models on Blackwell architecture. The revert streamlines the backend selection logic, removing the special handling for Kimi K2/K2.5 int4 models and maintaining the existing default behavior for DeepseekV3ForCausalLM with FP8/modelopt quantization. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that added default support for mxint4 flashinfer_trtllm moe gemm on Blackwell hardware. The revert cleanly removes the logic for detecting a specific int4 quantization configuration and the associated conditional logic for setting the MoE runner backend. The code is restored to its state prior to the reverted change.
|
fixed in #19696 |
Reverts #18136