Skip to content

[fix typo] expert_indicies -> expert_indices#19627

Merged
ishandhanani merged 2 commits intosgl-project:mainfrom
SoluMilken:fix-typo-indicies
Mar 2, 2026
Merged

[fix typo] expert_indicies -> expert_indices#19627
ishandhanani merged 2 commits intosgl-project:mainfrom
SoluMilken:fix-typo-indicies

Conversation

@SoluMilken
Copy link
Copy Markdown
Contributor

@SoluMilken SoluMilken commented Mar 1, 2026

Motivation

Fix a common typo. The word indices was misspelled as indicies. Correcting this ensures consistency and improves codebase searchability.

Modifications

  • Renamed expert_indicies to expert_indices in the relevant files.

Accuracy Tests

N/A. (Rename-only change)

Benchmarking and Profiling

N/A.

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@github-actions github-actions bot added the quant LLM Quantization label Mar 1, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important code quality issue by correcting a persistent typo. The variable expert_indicies has been consistently renamed to expert_indices throughout the relevant files, improving code readability and maintainability without altering any functionality.

Highlights

  • Typo Correction: Renamed the variable expert_indicies to expert_indices across the codebase to fix a common misspelling, enhancing consistency and searchability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/sglang/srt/models/mixtral_quant.py
    • Corrected the spelling of expert_indicies to expert_indices.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a typo by renaming expert_indicies to expert_indices in python/sglang/srt/models/mixtral_quant.py. The change is correct and improves code consistency and searchability. The scope of the change is limited to this renaming, and no other issues were identified in the modified code.

@SoluMilken SoluMilken marked this pull request as ready for review March 1, 2026 15:46
@b8zhong
Copy link
Copy Markdown
Collaborator

b8zhong commented Mar 1, 2026

/tag-and-rerun-ci

@b8zhong b8zhong enabled auto-merge (squash) March 1, 2026 18:00
@github-actions github-actions bot added the run-ci label Mar 1, 2026
@ishandhanani ishandhanani disabled auto-merge March 2, 2026 01:37
@ishandhanani ishandhanani merged commit 20282f5 into sgl-project:main Mar 2, 2026
7 of 8 checks passed
@SoluMilken SoluMilken deleted the fix-typo-indicies branch March 2, 2026 16:09
Kangyan-Zhou pushed a commit to Kangyan-Zhou/sglang that referenced this pull request Mar 4, 2026
Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
magicYang1573 pushed a commit to magicYang1573/sglang that referenced this pull request Mar 9, 2026
Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quant LLM Quantization run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants