[AMD] [CI] Add Tests for Aiter Allreduce Fusion#19417
Conversation
…le jobs run through workflow dispatch
Summary of ChangesHello @bingxche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new test suite into the continuous integration (CI) system, specifically targeting AMD GPU environments. The change ensures that a particular set of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
cc @yctseng0211 |
There was a problem hiding this comment.
Code Review
This pull request successfully adds a new test suite entry for AMD hardware, which aligns with the goal of reformatting and expanding tests for Aiter Allreduce Fusion. The change is functionally correct, but there's an opportunity to improve the readability and maintainability of the test suite list by ensuring alphabetical ordering.
…he test lasts very short compared to runner init time, will cause longer queue time for 8-gpu-runner
|
Integrated with PR #19834 |
Motivation
Reformat
Aiter Allreduce Fusiontests introduced by PR #13747Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci