-
Notifications
You must be signed in to change notification settings - Fork 5.4k
MFU metrics in Prometheus #19395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kangyan-Zhou
merged 8 commits into
sgl-project:main
from
aramasethu:feature/mfu-metrics
Mar 30, 2026
Merged
MFU metrics in Prometheus #19395
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ef8d031
add enable_mfu_metrics server arg
aramasethu 7836107
add estimated_flops, read_bytes, write_bytes_per_gpu counters
aramasethu b1f69dc
Add attention FLOPs and weight/activation byte estimates for prefill/…
aramasethu 036bf4b
add gate-on/gate-off tests for MFU metrics
aramasethu 705426c
add MFU-gated estimated FLOPs and memory bandwidth metrics
aramasethu 3332466
Add MFU stats to log
aramasethu c84c2e2
resolced CI error
aramasethu db867ca
merge log_decode_stats_every_iteration
aramasethu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sufeng-buaa Does this metric have any side effect?
If not should we just reuse the flag above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think calculating it once per batch still costs time in every round. Even though the overlap scheduling mechanism may hide that overhead. We already have a lot of metric-related code, and if it keeps growing, it might eventually turn into a performance problem. Honestly, I think even the existing metrics should be managed in different levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kangyan-Zhou @sufeng-buaa any next steps on this? Would love to help out / contribute in any way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any more comments. Does @Kangyan-Zhou think anything else needs to be changed?