[Bench][gsm8k] add openai-compatible backend#19231
[Bench][gsm8k] add openai-compatible backend#19231vladnosiv wants to merge 9 commits intosgl-project:mainfrom
Conversation
Signed-off-by: Vladislav Nosivskoy <vladnosiv@gmail.com>
Summary of ChangesHello @vladnosiv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the benchmarking capabilities by introducing support for OpenAI-compatible API endpoints. This allows users to evaluate models deployed behind such interfaces, like NVIDIA Dynamo, using existing benchmark scripts. The changes involve adding new configuration options and a dedicated API interaction layer, making the benchmarking process more versatile and adaptable to various deployment environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for an OpenAI-compatible backend for benchmarking, which is a valuable addition for testing in diverse environments. The implementation is well-structured and the changes are clear. I have provided a couple of suggestions for the python/sglang/test/test_utils.py file to enhance code conciseness and robustness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/tag-and-rerun-ci |
Signed-off-by: Vladislav Nosivskoy <vladnosiv@gmail.com>
|
sorry, gemini broke code format, need restart ci |
Motivation
This PR adds support for running benchmark/*/bench_other.py against an OpenAI compatible API endpoint.
The main motivation is enabling accuracy testing on top of NVIDIA Dynamo deployments, where only an OpenAI-compatible endpoint is available. Without this, existing bench_other.py scripts cannot be used directly for those environments.
Accuracy Tests
Ran GSM8K benchmark via OpenAI-compatible endpoint:
Result: