Conversation
Replace sgl_fused_add_rmsnorm in sgl-kernel with direct delegation to flashinfer.fused_add_rmsnorm JIT implementation. Remove fused_add_rms_norm_kernel.cu and associated AOT registrations. Update tests and benchmarks to include AOT vs JIT vs flashinfer comparison.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Johnsonms
marked this pull request as ready for review
February 23, 2026 04:15
Johnsonms
requested review from
BBuf,
DarkSharpness,
FlamingoPg,
HaiShaw,
ispobock,
merrymercy,
yizhang2077 and
zhyncs
as code owners
February 23, 2026 04:15
Collaborator
|
Thanks @Johnsonms! This has since landed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#17865
sgl_fused_add_rmsnorm in sgl-kernel wraps flashinfer::norm::FusedAddRMSNorm directly. Since FlashInfer already exposes
fused_add_rmsnorm as a first-class JIT-compiled Python function, maintaining a separate AOT copy adds unnecessary build complexity.
This PR removes the AOT kernel and delegates directly to flashinfer.fused_add_rmsnorm, following the same approach as #18999
(bmm_fp8) and the activation kernel migration.
The existing custom JIT kernel in sglang.jit_kernel.norm is retained for use cases requiring it, while the public
sgl_kernel.fused_add_rmsnorm API delegates to flashinfer which handles all hidden sizes and preserves the enable_pdl parameter.
Modifications
flashinfer.fused_add_rmsnorm, preserving the existing enable_pdl API
batch sizes × 10 hidden sizes)
Accuracy Tests
python -m pytest sgl-kernel/tests/test_norm.py -v -sBenchmarking and Profiling
python python/sglang/jit_kernel/benchmark/bench_fused_add_rmsnorm.pyChecklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci