[AMD][DO NOT MERGE] Fix MI35x DeepSeek-V3.2 nightly timeout failures - #19110
Closed
michaelzhang-ai wants to merge 1 commit into
Closed
michaelzhang-ai wants to merge 1 commit into
michaelzhang-ai wants to merge 1 commit into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
michaelzhang-ai
force-pushed
the
fix/mi35x-remove-ephemeral-data2-paths
branch
2 times, most recently
from
February 23, 2026 19:54
d849666 to
86297d9
Compare
MI35x DSv32 accuracy tests hardcoded HF_HOME to /data2/models/huggingface, which is ephemeral pod-local storage. When pods are recycled, model weights (~400GB) must be re-downloaded, exceeding test timeouts. The download never completes within the test timeout, and partial downloads are lost when the container exits, creating a self-perpetuating failure. Changes: - Remove hardcoded /data2 HF_HOME/HF_HUB_CACHE from 3 DSv32 MI35x accuracy test files (eval, mtp_eval, dp_eval) so they inherit HF_HOME=/sgl-data/hf-cache from the CI container - Add pre-cache step (snapshot_download, 240-min timeout) before each of the 8 MI35x DSv32 test jobs across both ROCm 7.0 and 7.2 workflows - Pre-cache checks if model is already cached before downloading - Add temporary pull_request triggers for CI testing
michaelzhang-ai
force-pushed
the
fix/mi35x-remove-ephemeral-data2-paths
branch
from
February 23, 2026 19:58
86297d9 to
cfe0b5c
Compare
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The nightly MI35x DeepSeek-V3.2 tests (
nightly-perf-8-gpu-mi35x-deepseek-v32-basic,nightly-accuracy-8-gpu-mi35x-deepseek-v32, etc.) started failing with exit code 255 (timeout) since Feb 21. Feb 20 and earlier were green.Root Cause
MI35x Kubernetes pod was recycled, causing:
CACHE_VOLUME=""inamd_ci_start_container.sh→ all caches (HF models, MIOpen kernels, Triton kernels) go to ephemeral container storageEvidence:
Additionally, DSv32 accuracy tests hardcoded
HF_HOMEto/data2/models/huggingface(ephemeral pod-local storage), overriding the CI container's persistent volume path even when available.Modifications
/data2paths from 3 DSv32 MI35x accuracy test files so they inheritHF_HOME=/sgl-data/hf-cachefrom the CI containersnapshot_downloadwith 240-min timeout) before each of the 8 MI35x DSv32 test jobs across both ROCm 7.0 and 7.2 workflowsFiles changed
nightly-test-amd.ymlnightly-test-amd-rocm720.ymltest_deepseek_v32_eval_mi35x.py/data2HF_HOME overridetest_deepseek_v32_mtp_eval_mi35x.py/data2HF_HOME overridetest_deepseek_v32_dp_eval_mi35x.py/data2HF_HOME overridePlease help review. @yctseng0211, @bingxche.
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci