Skip to content

Update rocm7.2 Dockerfile to install amdsmi for QuickReduce Initialization #19091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaiShaw merged 2 commits into from
Feb 23, 2026
Merged

Update rocm7.2 Dockerfile to install amdsmi for QuickReduce Initialization #19091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
950aeba
Install AMD SMI Python package in Dockerfile
clintg6 Feb 20, 2026
14df25a
Modify AMD SMI package installation command
clintg6 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker/rocm720.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ USER root
RUN python -m pip install --upgrade pip && pip install setuptools_scm
RUN apt-get purge -y sccache; python -m pip uninstall -y sccache; rm -f "$(which sccache)"

# Install AMD SMI Python package from ROCm distribution
RUN cd /opt/rocm/share/amd_smi && python3 -m pip install --no-cache-dir .

WORKDIR /sgl-workspace

# -----------------------
Expand Down Expand Up @@ -260,7 +263,7 @@ RUN /bin/bash -lc 'set -euo pipefail; \
libgtest-dev libgmock-dev \
libprotobuf-dev protobuf-compiler libgflags-dev libsqlite3-dev \
python3 python3-dev python3-setuptools python3-pip python3-apt \
gcc libtinfo-dev zlib1g-dev libedit-dev libxml2-dev \
gcc libtinfo-dev zlib1g-dev libedit-dev libxml2-dev vim \
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding vim is useful for debugging, but it increases the image size and attack surface. For production images, it's generally recommended to keep them as minimal as possible. If vim is only needed for development or debugging, consider creating a separate development Dockerfile or installing it on-the-fly when needed inside a running container.

Copy link
Copy Markdown
Contributor Author

@clintg6 clintg6 Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vim is standard in the rocm7.0 SGLang docker images

cmake ninja-build pkg-config libstdc++6 software-properties-common \
&& rm -rf /var/lib/apt/lists/*; \
\
Expand Down
Loading