Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
Thanks @Johnsonms! The target tree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#17865
Modifications
Migrate moe_sum_reduce from the AOT sgl-kernel build to the JIT kernel system (python/sglang/jit_kernel/), following the same pattern established for moe_topk_sigmoid and moe_topk_softmax.
New files:
Key implementation notes:
__nv_bfloat16>) — zero overhead for fp16/fp32
Accuracy Tests
677 tests pass, covering:
hidden dims (256, 1024, 4096)
677 passed in 17.80s
Correctness diff (JIT vs AOT):
tokens= 64 hidden= 4096 topk=4 output=✓ [OK]
tokens= 512 hidden= 7168 topk=8 output=✓ [OK]
tokens= 1024 hidden= 2048 topk=2 output=✓ [OK]
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci