Add aiter attention support in prefill-attention-backend of gpt-oss#18282
Merged
HaiShaw merged 3 commits intosgl-project:mainfrom Mar 2, 2026
Merged
Add aiter attention support in prefill-attention-backend of gpt-oss#18282HaiShaw merged 3 commits intosgl-project:mainfrom
HaiShaw merged 3 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
HaiShaw
approved these changes
Mar 2, 2026
Kangyan-Zhou
pushed a commit
to Kangyan-Zhou/sglang
that referenced
this pull request
Mar 4, 2026
…gl-project#18282) Co-authored-by: wunhuang <wunhuang@amd.com>
magicYang1573
pushed a commit
to magicYang1573/sglang
that referenced
this pull request
Mar 9, 2026
…gl-project#18282) Co-authored-by: wunhuang <wunhuang@amd.com>
Wangzheee
pushed a commit
to Wangzheee/sglang
that referenced
this pull request
Mar 21, 2026
…gl-project#18282) Co-authored-by: wunhuang <wunhuang@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the attention performance on ROCm platform.
Modifications
aiter_backend.py to support sliding window attention with sink
server_args.py to add "aiter" for supporting list
Accuracy Tests
Server command
SGLANG_USE_AITER=1 python3 -m sglang.launch_server --model-path /dockerx/data/models/openai/gpt-oss-120b/ --tp 8 --trust-remote-code --chunked-prefill-size 130172 --max-running-requests 128 --mem-fraction-static 0.85 --prefill-attention-backend aiter --decode-attention-backend triton --port 8000Client command
/sglang# python3 benchmark/gsm8k/bench_sglang.py --num-questions 2000 --parallel 2000 --port 8000 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1319/1319 [00:50<00:00, 26.00it/s] Accuracy: 0.829 Invalid: 0.014 Latency: 86.113 s Output throughput: 5072.316 token/sBenchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci