Revert broken sgl_kernel exclusion patterns in paths-filter#18193
Merged
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom Feb 3, 2026
Merged
Revert broken sgl_kernel exclusion patterns in paths-filter#18193Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
Conversation
…project#18054)" This reverts commit cd31540.
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
charlesHsuGG
pushed a commit
to charlesHsuGG/sglang
that referenced
this pull request
Feb 5, 2026
sfiisf
pushed a commit
to sfiisf/sglang
that referenced
this pull request
Feb 5, 2026
RubiaCx
pushed a commit
to RubiaCx/sglang
that referenced
this pull request
Feb 8, 2026
Johnsonms
pushed a commit
to Johnsonms/sglang
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts commit cd31540 ("Improve Per Commit Test job filtering for sglang-kernel (#18054)") which introduced broken exclusion patterns in the
sgl_kernelfilter.Problem
The exclusion patterns added in #18054 caused
dorny/paths-filterto incorrectly marksgl_kernel=truefor all PRs, even those that don't touch anysgl-kernel/files.For example, PR #17706 only modified:
python/sglang/srt/layers/radix_attention.pypython/sglang/srt/model_executor/piecewise_cuda_graph_runner.pypython/sglang/srt/models/qwen3_next.pytest/registered/models/test_qwen3_next_models_pcg.pyBut the CI run incorrectly detected
sgl_kernel=trueand triggered unnecessary kernel builds/tests.Root Cause
The
dorny/paths-filteraction usespredicate-quantifier: 'some'by default, meaning if ANY pattern matches, the filter returns true.The exclusion patterns like
!sgl-kernel/pyproject_cpu.tomlare interpreted as: "match any file that is NOTsgl-kernel/pyproject_cpu.toml".This means
python/sglang/srt/layers/radix_attention.pymatches the exclusion pattern (because it's not that file), causing the entiresgl_kernelfilter to return true.From the CI logs:
Solution
Revert to the simple
sgl-kernel/**pattern which correctly matches only files under thesgl-kernel/directory.If we want to exclude certain files in the future, we should use one of these approaches:
sgl-kernel/!(pyproject_cpu.toml|README.md)References:
Test plan
sgl-kernel/no longer trigger kernel buildssgl-kernel/still correctly trigger kernel builds🤖 Generated with Claude Code