Skip to content

[Docs] Add Falcon H1, Hunyuan-Large, Qwen3-Omni support and update Diffusion usage#17888

Merged
zhaochenyang20 merged 31 commits intosgl-project:mainfrom
pokymono:main
Feb 6, 2026
Merged

[Docs] Add Falcon H1, Hunyuan-Large, Qwen3-Omni support and update Diffusion usage#17888
zhaochenyang20 merged 31 commits intosgl-project:mainfrom
pokymono:main

Conversation

@pokymono
Copy link
Copy Markdown
Contributor

@pokymono pokymono commented Jan 28, 2026

Motivation

The documentation for supported models was missing models such as Falcon H1, Hunyuan-Large, and Qwen3-Omni.
Adding a Diffusion to Basic Usage for better guidance.

Modifications

New Model Support:
Generative Models: Added Falcon H1 (0.5B–34B Hybrid Mamba-Transformer) and Hunyuan-Large (389B MoE).
Multimodal Models: Added Step3-VL (10B) and Qwen3-Omni (Omni-modal MoE).

Basic Usage:
Added/Updated Diffusion documentation in the Basic Usage section to provide clear guidance on diffusion language models as requested.

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@github-actions github-actions bot added documentation Improvements or additions to documentation Multi-modal multi-modal language model labels Jan 28, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @pokymono, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's documentation by incorporating several newly supported large language models and multimodal models. It also introduces a structured guide for diffusion models, distinguishing between those used for image/video generation and those for text generation, thereby improving clarity and discoverability for users.

Highlights

  • New Generative Model Support: Added documentation for new generative models, including Falcon H1 (a hybrid Mamba-Transformer architecture) and Hunyuan-Large (a 389B Mixture of Experts model).
  • New Multimodal Model Support: Included new multimodal models, Step3-VL (a 10B VLM) and Qwen3-Omni (an omni-modal MoE model), in the supported models list.
  • Enhanced Diffusion Model Documentation: Introduced a dedicated documentation page for Diffusion models, categorizing them into image/video generation and diffusion language models, and updated existing diffusion model documentation to provide clearer cross-references.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pokymono pokymono changed the title [Docs] [Docs] Add Falcon H1, Hunyuan-Large, Qwen3-Omni support and update Diffusion usage Jan 28, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to include newly supported models like Falcon H1, Hunyuan-Large, Step3-VL, and Qwen3-Omni. It also adds a new page for diffusion models, improving the overall structure and clarity of the documentation. The changes are well-executed, but I found a minor formatting issue in one of the updated tables.

@pokymono
Copy link
Copy Markdown
Contributor Author

@Ratish1 Apologies for the previous PR, please check this one

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this file?, we already have this

basic_usage is model-specific folder only

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adarsh asked me to add Diffusion in basic usage.

@Ratish1
Copy link
Copy Markdown
Collaborator

Ratish1 commented Jan 28, 2026

Also @pokymono , apply the gemini fix, there is a clear render bug for that file. Fix the lint error aswell

@Ratish1
Copy link
Copy Markdown
Collaborator

Ratish1 commented Jan 28, 2026

There still seems to be a lint error, make sure you are running the pre-commit command

Copy link
Copy Markdown
Collaborator

@Ratish1 Ratish1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc: @adarshxs

@adarshxs
Copy link
Copy Markdown
Collaborator

LGTM. cc @mickqian
image

pokymono and others added 10 commits January 30, 2026 12:57
Co-authored-by: Ratish P <114130421+Ratish1@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…_models with sub sections based on categories.
@github-actions github-actions bot added blackwell SM100/SM120 npu diffusion SGLang Diffusion mthreads labels Feb 6, 2026
@pokymono
Copy link
Copy Markdown
Contributor Author

pokymono commented Feb 6, 2026

@zhaochenyang20 updated

@adarshxs
Copy link
Copy Markdown
Collaborator

adarshxs commented Feb 6, 2026

LGTM cc @zhaochenyang20

@zhaochenyang20 zhaochenyang20 merged commit c850a8a into sgl-project:main Feb 6, 2026
46 checks passed
charlesHsuGG pushed a commit to charlesHsuGG/sglang that referenced this pull request Feb 9, 2026
…ffusion usage (sgl-project#17888)

Co-authored-by: Rishitshivam <164783543+Rishitshivam@users.noreply.github.com>
Co-authored-by: Ratish P <114130421+Ratish1@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Adarsh Shirawalmath <114558126+adarshxs@users.noreply.github.com>
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
…ffusion usage (sgl-project#17888)

Co-authored-by: Rishitshivam <164783543+Rishitshivam@users.noreply.github.com>
Co-authored-by: Ratish P <114130421+Ratish1@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Adarsh Shirawalmath <114558126+adarshxs@users.noreply.github.com>
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
@zhaochenyang20
Copy link
Copy Markdown
Collaborator

This doc is vibe-coded and introduces unexpected errors in our documentation. We shall spend more time evaluating this PR. @Ratish1

#19104

magicYang1573 pushed a commit to magicYang1573/sglang that referenced this pull request Mar 9, 2026
…ffusion usage (sgl-project#17888)

Co-authored-by: Rishitshivam <164783543+Rishitshivam@users.noreply.github.com>
Co-authored-by: Ratish P <114130421+Ratish1@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Adarsh Shirawalmath <114558126+adarshxs@users.noreply.github.com>
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
Wangzheee pushed a commit to Wangzheee/sglang that referenced this pull request Mar 21, 2026
…ffusion usage (sgl-project#17888)

Co-authored-by: Rishitshivam <164783543+Rishitshivam@users.noreply.github.com>
Co-authored-by: Ratish P <114130421+Ratish1@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Adarsh Shirawalmath <114558126+adarshxs@users.noreply.github.com>
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amd blackwell SM100/SM120 deepseek dependencies Pull requests that update a dependency file diffusion SGLang Diffusion documentation Improvements or additions to documentation lora mthreads Multi-modal multi-modal language model npu quant LLM Quantization sgl-kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants