Skip to content

Merge performance/accuracy test suites into regular stage-b suites#17609

Merged
Kangyan-Zhou merged 2 commits intomainfrom
ci/merge-performance-accuracy-suites
Jan 26, 2026
Merged

Merge performance/accuracy test suites into regular stage-b suites#17609
Kangyan-Zhou merged 2 commits intomainfrom
ci/merge-performance-accuracy-suites

Conversation

@alisonshao
Copy link
Copy Markdown
Collaborator

@alisonshao alisonshao commented Jan 22, 2026

Summary

  • Move tests from separate performance/accuracy suites to corresponding regular stage-b suites
  • Remove 5 dedicated workflow jobs (performance/accuracy don't need separate CI stages)
  • Increase partitions to keep avg time under 20 min
  • Update wait-for-stage-b expected job count (29 → 27)

Changes

Test files updated (9 files):

  • test_eval_accuracy_large.py: stage-b-test-small-1-gpu-accuracy → stage-b-test-small-1-gpu
  • test_moe_eval_accuracy_large.py: stage-b-test-large-2-gpu-accuracy → stage-b-test-large-2-gpu
  • test_vlm_perf_5090.py: stage-b-test-small-1-gpu-performance → stage-b-test-small-1-gpu
  • test_bench_one_batch_1gpu.py: stage-b-test-large-1-gpu-performance → stage-b-test-large-1-gpu
  • test_bench_serving_1gpu_part1.py: stage-b-test-large-1-gpu-performance → stage-b-test-large-1-gpu
  • test_bench_serving_1gpu_part2.py: stage-b-test-large-1-gpu-performance → stage-b-test-large-1-gpu
  • test_bench_serving_1gpu_large.py: stage-b-test-large-1-gpu-performance → stage-b-test-large-1-gpu
  • test_bench_serving_2gpu.py: stage-b-test-large-2-gpu-performance → stage-b-test-large-2-gpu
  • test_bench_one_batch_2gpu.py: stage-b-test-large-2-gpu-performance → stage-b-test-large-2-gpu

Workflow jobs removed:

  • stage-b-test-small-1-gpu-performance
  • stage-b-test-large-1-gpu-performance
  • stage-b-test-large-2-gpu-performance
  • stage-b-test-small-1-gpu-accuracy
  • stage-b-test-large-2-gpu-accuracy

Partition count updates (to keep avg time under 20 min):

  • stage-b-test-large-1-gpu: 12 → 14 partitions (19.0 min avg)
  • stage-b-test-large-2-gpu: 2 → 4 partitions (15.4 min avg)

@github-actions github-actions bot added the Multi-modal multi-modal language model label Jan 22, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @alisonshao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to optimize the continuous integration pipeline by integrating specialized performance and accuracy tests directly into the standard stage-b test suites. This consolidation reduces the overall number of distinct CI jobs, leading to a more efficient and less complex testing workflow without compromising test coverage.

Highlights

  • Test Suite Consolidation: Performance and accuracy test suites have been merged into their corresponding regular stage-b suites, streamlining the testing process.
  • CI Job Reduction: Five dedicated workflow jobs for performance and accuracy tests have been removed, simplifying the CI configuration.
  • CI Job Count Update: The expected job count for 'wait-for-stage-b' has been updated from 29 to 23 to reflect the removed jobs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/pr-test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CI test suites by merging separate performance and accuracy tests into their corresponding regular stage-b suites. This simplifies the CI setup by removing five dedicated workflow jobs. The changes involve updating the suite parameter in register_cuda_ci calls across nine test files and removing the now-obsolete suite names from the PER_COMMIT_SUITES list in test/run_suite.py. The changes are straightforward, consistent with the pull request's goal, and appear correct. I have no further comments.

@alisonshao
Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@alisonshao alisonshao force-pushed the ci/merge-performance-accuracy-suites branch 4 times, most recently from fd79a40 to 9755d44 Compare January 23, 2026 00:45
- Move tests from separate performance/accuracy suites to corresponding
  regular stage-b suites (small-1-gpu, large-1-gpu, large-2-gpu)
- Remove 5 dedicated workflow jobs:
  - stage-b-test-small-1-gpu-performance
  - stage-b-test-large-1-gpu-performance
  - stage-b-test-large-2-gpu-performance
  - stage-b-test-small-1-gpu-accuracy
  - stage-b-test-large-2-gpu-accuracy
- Increase partitions to keep avg time under 20 min:
  - stage-b-test-large-1-gpu: 12 → 14 partitions
  - stage-b-test-large-2-gpu: 2 → 4 partitions
- Add human_eval installation to stage-b jobs (for accuracy tests)
- Update wait-for-stage-b expected job count (29 → 27)
- Update pr-test-finish needs list

These tests are functionally equivalent to unit tests and don't need
separate CI stages.
@alisonshao alisonshao force-pushed the ci/merge-performance-accuracy-suites branch from 9755d44 to 23692c6 Compare January 26, 2026 01:48
@Kangyan-Zhou Kangyan-Zhou merged commit 30b3192 into main Jan 26, 2026
155 of 163 checks passed
@Kangyan-Zhou Kangyan-Zhou deleted the ci/merge-performance-accuracy-suites branch January 26, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Multi-modal multi-modal language model run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants