[NPU] [Bug Fix] Fix typo in npu device check in gpt_oss.py#17553
Merged
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom Jan 22, 2026
Merged
[NPU] [Bug Fix] Fix typo in npu device check in gpt_oss.py#17553Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
|
@Todobe @iforgetmyname pls review! |
iforgetmyname
approved these changes
Jan 22, 2026
Collaborator
|
sry for missed that typo when reviewing last support pr,and thx for the fix! |
Contributor
|
Indeed, as you said, thank you for your discovery and the bug fix. |
Collaborator
|
/tag-and-rerun-ci |
Kangyan-Zhou
pushed a commit
that referenced
this pull request
Jan 22, 2026
Johnsonms
pushed a commit
to Johnsonms/sglang
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NPU support for gpt-oss enabled through the following PR #14197 has a small typo in npu device check for activation. That needs to be fixed otherwise the default activation function will be set as per NPU backend irrespective on whichever device the model is executed.
Modifications
Fix typo in npu device check in gpt_oss.py