[Fix] Revert back to using CUTLASS mm_fp4 backend#17369
Conversation
Summary of ChangesHello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to resolve a performance degradation issue encountered when using FlashInfer's FP4 GEMM operations, specifically with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts the mm_fp4 backend to use 'cutlass' by default when the backend is set to 'auto'. This is a sensible temporary fix to address the performance degradation caused by flashinfer's auto-selection logic picking a suboptimal backend. The change is clear and directly addresses the issue described. I have one suggestion to improve maintainability.
|
/tag-and-rerun-ci |
|
/rerun-stage unit-test-backend-4-gpu-b200 |
|
✅ Triggered |
|
/rerun-stage unit-test-backend-4-gpu-b200 |
|
✅ Triggered |
|
B200 fp4 gemm tests passed |
…icit default
Motivation
After manually installing
nvidia-cudnn-cu13==9.18.0.77, it still seems to be worse (mm_fp4picks this when cudnn >= 9.15.xx and CUDA 13, so hold off on this change for now (otherwise API will pick incorrect backend)Issue reported in flashinfer-ai/flashinfer#2375
Modifications
Change it back to earlier behaviour.