fix: hicache with eagle didn't manage the draft model's kv cache.#17338
Closed
fix: hicache with eagle didn't manage the draft model's kv cache.#17338
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-run-ci-label |
Collaborator
Author
|
/tag-and-rerun-ci |
5 tasks
Collaborator
|
@ispobock should the draft model just re-compute when the cache is already evicted for the draft model? |
Collaborator
|
/rerun-stage stage-b-test-large-1-gpu |
Collaborator
Author
|
/rerun-stage stage-b-test-large-1-gpu |
Contributor
|
✅ Triggered |
Contributor
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When both speculative decoding and HiCache are enabled, the draft model KV cache is not managed by the HiRadix cache.
When the original draft model KV cache is evicted, but the target model hits HiCache, the draft model ends up drafting based on a random KV cache.
Modifications
Add dedicated L2 HiCache support for the draft model KV cache.
Accuracy Tests
Before the fix
When HiCache was triggered, the acceptance length dropped for the same request.
After the fix
The acceptance length stays almost the same.
see #16964
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci