Fix wrong kernel selection for int32/int64 indices#16912
Conversation
Summary of ChangesHello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request fully reverts the previously introduced feature 'Support JIT set kv cache' (#16273). The primary motivation for this revert is to address continuous integration (CI) failures that were occurring after the feature's introduction. The changes systematically remove all components related to the JIT KV-cache, including its custom CUDA kernel, Python bindings, benchmarking, testing, and its integration within the memory management system, aiming to restore stability to the CI pipeline. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/rerun-stage stage-c-test-large-4-gpu |
There was a problem hiding this comment.
Code Review
This pull request reverts the feature 'Support JIT set kv cache' due to CI breakages. The changes correctly remove the new JIT kernel for setting KV cache, including its implementation, benchmarks, and tests. The code in memory_pool.py that utilized this feature has been reverted to its previous implementation. The revert appears to be mostly complete. However, I've found a minor issue in a benchmark file that seems to be an incomplete part of the revert, which I've commented on.
|
✅ Triggered |
314e4e8 to
3cd69a1
Compare
|
/rerun-stage stage-c-test-large-4-gpu |
|
✅ Triggered |
3cd69a1 to
1b30c3b
Compare
|
/tag-and-rerun-ci |
|
/rerun-failed-ci |
Co-authored-by: DarkSharpness <2040703891@qq.com>
Bug introduced in #16273
CI breaks.