[AMD] Fix CI - unit-test-backend-1-gpu-amd-mi35x and unit-test-backend-2-gpu-amd, stage-b-test-small-1-gpu-amd#16675
Conversation
Summary of ChangesHello @yctseng0211, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to resolve a Continuous Integration (CI) failure, specifically targeting AMD environments. It achieves this by adjusting the configuration passed to a Triton-based fused Mixture-of-Experts (MoE) kernel, ensuring compatibility and preventing errors during execution. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a potential TypeError in the invoke_fused_moe_kernel function. The fused_moe_kernel is called with swap_ab as an explicit keyword argument, but the config dictionary, also passed as keyword arguments, could potentially contain the same key. This would cause a runtime error due to a duplicate argument. The fix correctly removes the swap_ab key from a copy of the config dictionary before the kernel invocation. This is a clean and safe solution that improves the robustness of the kernel invocation.
ced2b46 to
6757042
Compare
|
You can always install pre-commit in this repo so that you don't need to fix lint after push |
Motivation
Fix the ci failures:
https://github.com/sgl-project/sglang/actions/runs/20802527047/job/59750995718?pr=16529
https://github.com/sgl-project/sglang/actions/runs/20802527047/job/59750995708?pr=16529
https://github.com/sgl-project/sglang/actions/runs/20802527047/job/59750995712?pr=16529
https://github.com/sgl-project/sglang/actions/runs/20809567649/job/59771596544
Modifications
Accuracy Tests
AMD CI all green : https://github.com/sgl-project/sglang/actions/runs/20811570421?pr=16675
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.