Skip to content

[AMD CI] re-enable testcases missed when migrating ci test files#16535

Merged
HaiShaw merged 20 commits intosgl-project:mainfrom
bingxche:add-amd-ci
Jan 8, 2026
Merged

[AMD CI] re-enable testcases missed when migrating ci test files#16535
HaiShaw merged 20 commits intosgl-project:mainfrom
bingxche:add-amd-ci

Conversation

@bingxche
Copy link
Copy Markdown
Collaborator

@bingxche bingxche commented Jan 6, 2026

Motivation

PR #15563 and #15176 missed some testcases used in amd ci, this pr is to re-enable them.

Modifications

Test File Suite Notes
test_create_kvindices.py stage-b-test-small-1-gpu ✅ Enabled
test_radix_attention.py stage-b-test-small-1-gpu ✅ Enabled
test_torch_native_attention_backend.py stage-b-test-small-1-gpu ✅ Enabled
test_triton_attention_backend.py stage-b-test-small-1-gpu ✅ Enabled
test_triton_attention_kernels.py stage-b-test-small-1-gpu ⚠️ Disabled (placeholder)
test_triton_sliding_window.py stage-b-test-small-1-gpu ✅ Enabled
Test File Suite Notes
test_lora.py stage-b-test-small-1-gpu ✅ Enabled
test_lora_backend.py stage-b-test-small-1-gpu ⚠️ Disabled (issue #13107)
test_lora_eviction.py stage-b-test-small-1-gpu ✅ Enabled
test_lora_tp.py stage-b-test-large-2-gpu-amd ⚠️ Disabled (issue #13107)
test_multi_lora_backend.py stage-b-test-small-1-gpu ✅ Enabled

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@bingxche bingxche marked this pull request as ready for review January 6, 2026 03:38
@bingxche bingxche requested a review from alisonshao January 6, 2026 03:39
@alisonshao
Copy link
Copy Markdown
Collaborator

/rerun-stage stage-b-test-small-1-gpu-amd

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

✅ Triggered stage-b-test-small-1-gpu-amd to run independently (skipping dependencies).

It will not be shown in this page. Check the Actions tab for progress.

@alisonshao
Copy link
Copy Markdown
Collaborator

https://github.com/sgl-project/sglang/actions/runs/20737219495

@alisonshao
Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

@github-actions github-actions bot added the run-ci label Jan 6, 2026
@github-actions github-actions bot added the lora label Jan 6, 2026
@bingxche bingxche changed the title [AMD CI] re-enable testcases missed when migrating attention backend tests [AMD CI] re-enable testcases missed when migrating ci testfiles Jan 6, 2026
@bingxche bingxche changed the title [AMD CI] re-enable testcases missed when migrating ci testfiles [AMD CI] re-enable testcases missed when migrating ci test files Jan 6, 2026
@bingxche
Copy link
Copy Markdown
Collaborator Author

bingxche commented Jan 6, 2026

image

All CI tests passed.

cc: @yctseng0211 @michael-amd @saienduri

@alisonshao
Copy link
Copy Markdown
Collaborator

@alisonshao
Copy link
Copy Markdown
Collaborator

alisonshao commented Jan 6, 2026

can you add a reason for disabling test_triton_attention_kernels.py? do we know the reason?
Screenshot 2026-01-06 at 12 18 16 PM

Copy link
Copy Markdown
Collaborator

@michaelzhang-ai michaelzhang-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingxche
Copy link
Copy Markdown
Collaborator Author

bingxche commented Jan 7, 2026

can you add a reason for disabling test_triton_attention_kernels.py? do we know the reason? Screenshot 2026-01-06 at 12 18 16 PM

Thanks for your review Alison. This test need validation afterwards.

@yctseng0211
Copy link
Copy Markdown
Collaborator

yctseng0211 commented Jan 7, 2026

can you add a reason for disabling test_triton_attention_kernels.py? do we know the reason? Screenshot 2026-01-06 at 12 18 16 PM

Thanks for your review Alison. This test need validation afterwards.

@alisonshao will verify and add this test case in this PR #16559

@github-actions github-actions bot added the Multi-modal multi-modal language model label Jan 7, 2026
Copy link
Copy Markdown
Collaborator

@HaiShaw HaiShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict to solve

@yctseng0211
Copy link
Copy Markdown
Collaborator

conflict to solve

@HaiShaw conflict resolved

@HaiShaw HaiShaw merged commit f9c0426 into sgl-project:main Jan 8, 2026
60 of 84 checks passed
hnyls2002 pushed a commit that referenced this pull request Jan 8, 2026
)

Co-authored-by: michael-amd <michael.zhang@amd.com>
Co-authored-by: yctseng0211 <yctseng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amd lora Multi-modal multi-modal language model run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants