Skip to content

[AMD CI] re-enable testcases missed when migrating attention backend tests#16476

Closed
bingxche wants to merge 2 commits intomainfrom
fix-amd-ci
Closed

[AMD CI] re-enable testcases missed when migrating attention backend tests#16476
bingxche wants to merge 2 commits intomainfrom
fix-amd-ci

Conversation

@bingxche
Copy link
Copy Markdown
Collaborator

@bingxche bingxche commented Jan 5, 2026

Motivation

PR #15563 missed some testcases used in amd ci, this pr is to re-enable them.

Modifications

File AMD CI Registration
test_create_kvindices.py ✅ enabled, est_time=10
test_radix_attention.py ✅ enabled, est_time=100
test_torch_native_attention_backend.py ✅ enabled, est_time=150
test_triton_attention_backend.py ✅ enabled, est_time=200
test_triton_attention_kernels.py ⚠️ disabled, est_time=30
test_triton_sliding_window.py ✅ enabled, est_time=100

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @bingxche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the re-enablement of several attention backend test cases for AMD's Continuous Integration (CI) system. These tests were inadvertently missed during a previous migration. By registering these tests with the AMD CI, the change aims to expand test coverage and ensure the stability and correctness of attention mechanisms on AMD platforms.

Highlights

  • AMD CI Test Re-enablement: Re-enabled AMD CI for five attention backend test cases: test_create_kvindices.py, test_radix_attention.py, test_torch_native_attention_backend.py, test_triton_attention_backend.py, and test_triton_sliding_window.py.
  • Disabled AMD CI Test: Explicitly disabled AMD CI for test_triton_attention_kernels.py during this re-enablement phase.
  • CI Registration Update: Updated the CI registration logic in affected test files to include register_amd_ci alongside register_cuda_ci.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables several test cases for AMD CI by adding register_amd_ci calls to the respective test files. The changes are consistent with the goals outlined in the description and the summary table. I have one minor suggestion to improve the clarity of a disabled test case for better long-term maintainability.


# Triton attention kernel unit tests (decode, extend, prefill)
register_cuda_ci(est_time=30, suite="stage-b-test-small-1-gpu")
register_amd_ci(est_time=30, suite="stage-b-test-small-1-gpu", disabled=" ")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity and maintainability, it would be helpful to provide a more descriptive reason for disabling this test on AMD CI. A single space is not very informative for future developers who might wonder why this test is disabled. Providing a clear reason, for example "Triton kernels not yet supported on AMD", improves code readability.

Suggested change
register_amd_ci(est_time=30, suite="stage-b-test-small-1-gpu", disabled=" ")
register_amd_ci(est_time=30, suite="stage-b-test-small-1-gpu", disabled="Triton kernels not yet supported on AMD")

@bingxche bingxche marked this pull request as ready for review January 5, 2026 09:18
@bingxche bingxche closed this Jan 6, 2026
@bingxche bingxche deleted the fix-amd-ci branch January 6, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant