[AMD CI] re-enable testcases missed when migrating attention backend tests#16476
[AMD CI] re-enable testcases missed when migrating attention backend tests#16476
Conversation
Summary of ChangesHello @bingxche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses the re-enablement of several attention backend test cases for AMD's Continuous Integration (CI) system. These tests were inadvertently missed during a previous migration. By registering these tests with the AMD CI, the change aims to expand test coverage and ensure the stability and correctness of attention mechanisms on AMD platforms. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request re-enables several test cases for AMD CI by adding register_amd_ci calls to the respective test files. The changes are consistent with the goals outlined in the description and the summary table. I have one minor suggestion to improve the clarity of a disabled test case for better long-term maintainability.
|
|
||
| # Triton attention kernel unit tests (decode, extend, prefill) | ||
| register_cuda_ci(est_time=30, suite="stage-b-test-small-1-gpu") | ||
| register_amd_ci(est_time=30, suite="stage-b-test-small-1-gpu", disabled=" ") |
There was a problem hiding this comment.
For better clarity and maintainability, it would be helpful to provide a more descriptive reason for disabling this test on AMD CI. A single space is not very informative for future developers who might wonder why this test is disabled. Providing a clear reason, for example "Triton kernels not yet supported on AMD", improves code readability.
| register_amd_ci(est_time=30, suite="stage-b-test-small-1-gpu", disabled=" ") | |
| register_amd_ci(est_time=30, suite="stage-b-test-small-1-gpu", disabled="Triton kernels not yet supported on AMD") |
Motivation
PR #15563 missed some testcases used in amd ci, this pr is to re-enable them.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.