Skip to content

KV Cache Events with Attention DP bug fix (#16030) #16412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fridge003 merged 2 commits into from
Jan 19, 2026
Merged

KV Cache Events with Attention DP bug fix (#16030) #16412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5616a
KV Cache Events with Attention DP bug fix (#16030)
kartikx Jan 4, 2026
8fa60f3
Merge branch 'main' into kv-events-config
ishandhanani Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/sglang/srt/managers/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,6 @@ def __init__(
self.enable_metrics_for_all_schedulers = (
server_args.enable_metrics_for_all_schedulers
)
self.enable_kv_cache_events = bool(
server_args.kv_events_config and tp_rank == 0
)
self.enable_trace = server_args.enable_trace
self.stream_interval = server_args.stream_interval
self.spec_algorithm = SpeculativeAlgorithm.from_string(
Expand All @@ -313,6 +310,10 @@ def __init__(
)
)

self.enable_kv_cache_events = bool(
server_args.kv_events_config and self.attn_tp_rank == 0
)

# Init model configs
self.init_model_config()

Expand Down
5 changes: 4 additions & 1 deletion test/manual/test_kv_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
)
from sglang.srt.utils import kill_process_tree
from sglang.test.test_utils import (
DEFAULT_MLA_MODEL_NAME_FOR_TEST,
DEFAULT_SMALL_MODEL_NAME_FOR_TEST,
DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
DEFAULT_URL_FOR_TEST,
Expand Down Expand Up @@ -154,6 +155,8 @@ def test_kv_events_enabled(self):
pass

finally:
sub.close()
context.term()
kill_process_tree(process.pid)

def test_kv_events_attn_dp(self):
Expand All @@ -175,7 +178,7 @@ def test_kv_events_attn_dp(self):

# Launch sglang server with DP attention enabled
process = popen_launch_server(
"silence09/DeepSeek-R1-Small-2layers",
DEFAULT_MLA_MODEL_NAME_FOR_TEST,
DEFAULT_URL_FOR_TEST,
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
other_args=[
Expand Down
Loading