Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Is the |
6 tasks
59b07f4 to
03cfe1d
Compare
Collaborator
Author
Yes, del pixel_values is highly recommended. Updated. |
03cfe1d to
1f39ceb
Compare
Collaborator
|
/tag-and-rerun-ci |
JustinTong0323
approved these changes
Jan 6, 2026
1f39ceb to
b8e9e3b
Compare
Collaborator
Author
|
/rerun-failed-ci |
1 similar comment
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
4 tasks
michaelzhang-ai
pushed a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Jan 7, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
dsingal0
pushed a commit
to dsingal0/sglang
that referenced
this pull request
Feb 1, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Close #16106.
The feature Memory Pool based CUDA IPC has a fallback mechanism, if the slice can't be allocated, it will fallback to use the legacy Tensor.
If it is the case, the current implementation forgets to call D2H, the memory leak and OOM happens very frequently.
The fix is to align the fallback branch with the legacy path. Repro commands(without PR will OOM):
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist