[diffusion]: add E2E correctness tests for image and video models#16024
[diffusion]: add E2E correctness tests for image and video models#16024Ratish1 wants to merge 4 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @Ratish1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing infrastructure for SGlang Diffusion by introducing a comprehensive end-to-end functional correctness suite. This new suite verifies the expected behavior of image and video generation models, ensuring their reliability through checks for successful output generation, deterministic results with identical seeds, and robust handling of API errors across both single and multi-GPU environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a suite of end-to-end correctness tests for image and video diffusion models, which is a great addition to ensure functional reliability. The implementation is well-structured, with new test cases for both 1-GPU and 2-GPU setups, and a shared mixin for test logic. My review focuses on improving the test implementation to prevent redundant executions and enhance maintainability. I've identified a high-severity issue where a test is run twice and a couple of medium-severity issues related to hardcoded values that could be made more dynamic.
python/sglang/multimodal_gen/test/server/test_server_correctness.py
Outdated
Show resolved
Hide resolved
python/sglang/multimodal_gen/test/server/test_server_2_gpu_correctness.py
Outdated
Show resolved
Hide resolved
python/sglang/multimodal_gen/test/server/test_server_correctness.py
Outdated
Show resolved
Hide resolved
python/sglang/multimodal_gen/test/server/test_server_correctness.py
Outdated
Show resolved
Hide resolved
|
duplicate with #20139, thanks for your contribution |
Motivation
This PR introduces a dedicated functional correctness suite for SGlang Diffusion, complementing the existing performance tests. #12987Modifications
testcase_configs.py: added CORRECTNESS_1_GPU_CASES and CORRECTNESS_2_GPU_CASEStest_server_correctness.py: Implemented a 1-GPU suite featuring bit-identical seed determinism and API error code (400/422) verification.test_server_2_gpu_correctness.py: Added a 2-GPU suite for Wan 14BAccuracy Tests
Benchmarking and Profiling
Checklist