update benchmark README to use --fp8-gemm-backend instead of env var#15689
Conversation
Summary of ChangesHello @leejnau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for DeepSeek V3 benchmarks within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the benchmark README for DeepSeek V3, replacing the deprecated SGLANG_ENABLE_FLASHINFER_GEMM environment variable with the --fp8-gemm-backend command-line argument. The change is correct and aligns with recent updates. I've added one suggestion to improve the readability of the command by splitting it into multiple lines, consistent with other examples in the document.
| ``` | ||
| SGLANG_ENABLE_JIT_DEEPGEMM=false SGLANG_ENABLE_FLASHINFER_GEMM=true bash python3 -m sglang.launch_server --model-path=deepseek-ai/DeepSeek-R1-0528 --host=0.0.0.0 --port=8000 --tensor-parallel-size=8 --cuda-graph-max-bs 128 --max-running-requests 128 --mem-fraction-static 0.82 --kv-cache-dtype fp8_e4m3 --chunked-prefill-size 32768 --max-prefill-tokens 32768 --scheduler-recv-interval 30 --stream-interval 30 | ||
| ```bash | ||
| SGLANG_ENABLE_JIT_DEEPGEMM=false python3 -m sglang.launch_server --model-path=deepseek-ai/DeepSeek-R1-0528 --host=0.0.0.0 --port=8000 --tensor-parallel-size=8 --cuda-graph-max-bs 128 --max-running-requests 128 --mem-fraction-static 0.82 --kv-cache-dtype fp8_e4m3 --chunked-prefill-size 32768 --max-prefill-tokens 32768 --scheduler-recv-interval 30 --stream-interval 30 --fp8-gemm-backend flashinfer_trtllm |
There was a problem hiding this comment.
For better readability, consider splitting this long command into multiple lines using backslashes, similar to other examples in this file.
| SGLANG_ENABLE_JIT_DEEPGEMM=false python3 -m sglang.launch_server --model-path=deepseek-ai/DeepSeek-R1-0528 --host=0.0.0.0 --port=8000 --tensor-parallel-size=8 --cuda-graph-max-bs 128 --max-running-requests 128 --mem-fraction-static 0.82 --kv-cache-dtype fp8_e4m3 --chunked-prefill-size 32768 --max-prefill-tokens 32768 --scheduler-recv-interval 30 --stream-interval 30 --fp8-gemm-backend flashinfer_trtllm | |
| SGLANG_ENABLE_JIT_DEEPGEMM=false python3 -m sglang.launch_server \ | |
| --model-path=deepseek-ai/DeepSeek-R1-0528 \ | |
| --host=0.0.0.0 \ | |
| --port=8000 \ | |
| --tensor-parallel-size=8 \ | |
| --cuda-graph-max-bs 128 \ | |
| --max-running-requests 128 \ | |
| --mem-fraction-static 0.82 \ | |
| --kv-cache-dtype fp8_e4m3 \ | |
| --chunked-prefill-size 32768 \ | |
| --max-prefill-tokens 32768 \ | |
| --scheduler-recv-interval 30 \ | |
| --stream-interval 30 \ | |
| --fp8-gemm-backend flashinfer_trtllm |
Motivation
Update documentation to reflect changes in: #14379
Modifications
Update benchmark README file for DeepSeek V3.
Accuracy Tests
N/A
Benchmarking and Profiling
N/A
Checklist